Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide data_only mode for wb_load() #181

Merged
merged 2 commits into from
May 19, 2022
Merged

provide data_only mode for wb_load() #181

merged 2 commits into from
May 19, 2022

Conversation

JanMarvin
Copy link
Owner

This allows reading a striped down version of wbWorkbook with only sheet_data. Thought that this would speed read_xlsx a bit up, but could not measure any difference

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2022

Codecov Report

Merging #181 (2a2f7f6) into main (ddb8ea2) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   78.40%   78.44%   +0.04%     
==========================================
  Files          35       35              
  Lines        7406     7406              
==========================================
+ Hits         5807     5810       +3     
+ Misses       1599     1596       -3     
Impacted Files Coverage Δ
R/readWorkbook.R 95.65% <100.00%> (-0.10%) ⬇️
R/wb_functions.R 98.52% <100.00%> (+0.37%) ⬆️
R/wb_load.R 95.08% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddb8ea2...2a2f7f6. Read the comment docs.

@JanMarvin JanMarvin merged commit 41273c9 into main May 19, 2022
@JanMarvin JanMarvin deleted the data_only branch May 19, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants