Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

113 sheet funs #183

Merged
merged 34 commits into from
Jun 16, 2022
Merged

113 sheet funs #183

merged 34 commits into from
Jun 16, 2022

Conversation

jmbarbone
Copy link
Collaborator

resolves #113

@jmbarbone jmbarbone mentioned this pull request May 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #183 (9d36b49) into main (d5a8118) will decrease coverage by 3.56%.
The diff coverage is 78.53%.

❗ Current head 9d36b49 differs from pull request most recent head 37088d8. Consider uploading reports for the commit 37088d8 to get more accurate results

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   84.33%   80.77%   -3.57%     
==========================================
  Files          38       36       -2     
  Lines        8637     7447    -1190     
==========================================
- Hits         7284     6015    -1269     
- Misses       1353     1432      +79     
Impacted Files Coverage Δ
R/helperFunctions.R 76.78% <ø> (+5.04%) ⬆️
R/class-workbook.R 73.48% <75.49%> (-3.11%) ⬇️
R/illegal-characters.R 93.75% <93.75%> (+16.82%) ⬆️
R/class-workbook-utils.R 97.87% <100.00%> (+0.25%) ⬆️
R/class-workbook-wrappers.R 94.06% <100.00%> (+8.72%) ⬆️
R/write.R 80.97% <100.00%> (-0.23%) ⬇️
R/names.R 5.88% <0.00%> (-94.12%) ⬇️
R/wb_styles.R 47.25% <0.00%> (-15.95%) ⬇️
src/styles_xml.cpp 79.43% <0.00%> (-13.85%) ⬇️
R/class-style_mgr.R 78.50% <0.00%> (-10.20%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a8118...37088d8. Read the comment docs.

@jmbarbone jmbarbone marked this pull request as ready for review June 9, 2022 13:31
Copy link
Owner

@JanMarvin JanMarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Love it!

tests/testthat/test-class-workbook-utils.R Outdated Show resolved Hide resolved
@jmbarbone jmbarbone merged commit aca53de into main Jun 16, 2022
@JanMarvin JanMarvin deleted the 113-sheet-funs branch October 27, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include current_sheet(), next_sheet() waivers/private fields
3 participants