Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[styles] Table styles read/write #194

Merged
merged 3 commits into from
May 22, 2022
Merged

[styles] Table styles read/write #194

merged 3 commits into from
May 22, 2022

Conversation

JanMarvin
Copy link
Owner

  • fix reading and writing xr9 styles from R
  • fix styles c++ read/write

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2022

Codecov Report

Merging #194 (23660f8) into main (799bae0) will increase coverage by 1.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   81.70%   82.76%   +1.05%     
==========================================
  Files          35       35              
  Lines        7385     7386       +1     
==========================================
+ Hits         6034     6113      +79     
+ Misses       1351     1273      -78     
Impacted Files Coverage Δ
R/class-workbook.R 75.63% <100.00%> (ø)
R/conditional_formatting.R 72.08% <100.00%> (ø)
src/styles_xml.cpp 93.27% <100.00%> (+13.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799bae0...23660f8. Read the comment docs.

@JanMarvin JanMarvin merged commit 506cabe into main May 22, 2022
@JanMarvin JanMarvin deleted the tableStyles branch May 22, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants