Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R/load&save] change slicer numbers. closes #203 #205

Merged
merged 1 commit into from
May 27, 2022
Merged

[R/load&save] change slicer numbers. closes #203 #205

merged 1 commit into from
May 27, 2022

Conversation

JanMarvin
Copy link
Owner

This is a fix for the current slicer behaviour. And another call for a check when saving that all relationships are available.

…icer behaviour. And another call for a check when saving that all relationships are available.
@JanMarvin JanMarvin added bug 🐛 Something isn't working internal 🔧 labels May 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #205 (c56adbd) into main (805a669) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   82.66%   82.65%   -0.02%     
==========================================
  Files          36       36              
  Lines        7397     7398       +1     
==========================================
  Hits         6115     6115              
- Misses       1282     1283       +1     
Impacted Files Coverage Δ
R/class-workbook.R 75.61% <0.00%> (-0.04%) ⬇️
R/wb_load.R 95.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 805a669...c56adbd. Read the comment docs.

@JanMarvin JanMarvin merged commit 2b83cca into main May 27, 2022
@JanMarvin JanMarvin deleted the gh_203 branch May 27, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working internal 🔧
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants