[R/save] check that comments are saved correctly #209
Conversation
|
|
||
| test_that("load comments", { | ||
|
|
||
| fl <- system.file("extdata", "pivot_notes.xlsx", package = "openxlsx2") |
There was a problem hiding this comment.
Wonderful, did not add it and purged my folder 😢
…nts%s.xml is written
…example, which is lost)
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 82.70% 83.24% +0.54%
==========================================
Files 36 36
Lines 7400 7414 +14
==========================================
+ Hits 6120 6172 +52
+ Misses 1280 1242 -38
Continue to review full report at Codecov.
|
… counting might no longer reflect the worksheet_rels
|
@jmbarbone part of the mess is caused by me removing strict naming conventions. This was previously a bit broken in openxlsx and (hopefully) is now a bit better implemented, though it is still far from what I want. I'd prefer a reference manager counting what goes in and where and collecting everything when writing the final output. Having all these tingling relationships hardcoded in various files is so annoying. Though fixing it correctly will be another mammoth of a task. Especially because we have references to various files in different places.
|
|
Oh and once this and the encoding part are merged, I'd like to make a minor version bump. Hopefully we've ironed out a good fraction of initial issues |
…is an entry in worksheets_rels, we pick it and create our xml name from it. content type matches this id.
I've crafted a new example file that contains both issues.
comments1.xmlandcomments2.xml. Yet we try to save them with numbers matching their sheet index