Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

176 options #210

Merged
merged 3 commits into from
May 30, 2022
Merged

176 options #210

merged 3 commits into from
May 30, 2022

Conversation

jmbarbone
Copy link
Collaborator

Cleans up some of the options settings. May need to take a closer look at some of the outputs. I think the options only matter when writing data, so it should be safe enough to remove from everything else.

Resolves #176

@codecov-commenter
Copy link

Codecov Report

Merging #210 (e507a82) into main (a16dc8b) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   82.70%   82.61%   -0.09%     
==========================================
  Files          36       36              
  Lines        7400     7352      -48     
==========================================
- Hits         6120     6074      -46     
+ Misses       1280     1278       -2     
Impacted Files Coverage Δ
R/class-workbook.R 75.30% <ø> (-0.31%) ⬇️
R/conditional_formatting.R 71.79% <ø> (-0.29%) ⬇️
R/converters.R 42.30% <ø> (-7.70%) ⬇️
R/dates.R 90.62% <ø> (-0.29%) ⬇️
R/helperFunctions.R 79.20% <ø> (ø)
R/names.R 100.00% <ø> (ø)
R/utils.R 88.57% <ø> (ø)
R/wb_styles.R 46.86% <ø> (-0.39%) ⬇️
R/write.R 80.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a16dc8b...e507a82. Read the comment docs.

@JanMarvin JanMarvin mentioned this pull request May 28, 2022
@JanMarvin JanMarvin merged commit bba1ec3 into main May 30, 2022
@JanMarvin JanMarvin deleted the 176-options branch May 30, 2022 10:05
@JanMarvin
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review openxlsx_options()
3 participants