Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R/add_border] add_border and wb_add_border #220

Merged
merged 14 commits into from
Jun 6, 2022
Merged

[R/add_border] add_border and wb_add_border #220

merged 14 commits into from
Jun 6, 2022

Conversation

JanMarvin
Copy link
Owner

@JanMarvin JanMarvin commented Jun 5, 2022

Create borders for cell regions. This creates border styles for a specific region.

  • add tests
  • merge styles if possible. If cell as <xf../> node, copy the node and applyBorder and borderid. Otherwise if two or more cells share the style, they all would get the border.
  • inner grid (maybe providing a single style)

@JanMarvin
Copy link
Owner Author

unrelated fix for showGridLines option and newly introduced rowColHeaders option.

@JanMarvin
Copy link
Owner Author

Any clue why the test are complaining @jmbarbone ?

@jmbarbone
Copy link
Collaborator

Any clue why the test are complaining @jmbarbone ?

@JanMarvin, it looks like some weird roxygen2 behavior where the the lines changes in
237a1bd were being appended to the documentation.

@JanMarvin
Copy link
Owner Author

Thanks, didn't see that. Maybe because of the example in the wbWorkbook part

@JanMarvin JanMarvin merged commit 4f32476 into main Jun 6, 2022
@JanMarvin JanMarvin deleted the add_border branch June 6, 2022 11:08
@JanMarvin JanMarvin added this to To Do in styles via automation Jun 8, 2022
@JanMarvin JanMarvin moved this from To Do to Done in styles Jun 8, 2022
@JanMarvin JanMarvin mentioned this pull request Jun 9, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants