Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R/add_fill] provide add_fill helper #222

Merged
merged 9 commits into from
Jun 8, 2022
Merged

[R/add_fill] provide add_fill helper #222

merged 9 commits into from
Jun 8, 2022

Conversation

JanMarvin
Copy link
Owner

@JanMarvin JanMarvin commented Jun 6, 2022

  • add wb_add_fill()
  • add tests
  • optional every n-th row/col filled

@JanMarvin JanMarvin changed the title provide add_fill helper [R/add_fill] provide add_fill helper Jun 6, 2022
"<xf applyFill=\"1\" borderId=\"0\" fillId=\"2\" fontId=\"0\" numFmtId=\"0\" xfId=\"0\"/>",
"<xf applyFill=\"1\" fillId=\"2\"/>",
"<xf applyFill=\"1\" borderId=\"0\" fillId=\"3\" fontId=\"0\" numFmtId=\"0\" xfId=\"0\"/>",
"<xf applyFill=\"1\" fillId=\"3\"/>")
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor thing for a follow up PR, not sure why this second fill is written

@JanMarvin JanMarvin merged commit d5a8118 into main Jun 8, 2022
@JanMarvin JanMarvin deleted the add_fill branch June 8, 2022 00:01
@JanMarvin JanMarvin added this to To Do in styles via automation Jun 8, 2022
@JanMarvin JanMarvin moved this from To Do to Done in styles Jun 8, 2022
@JanMarvin JanMarvin mentioned this pull request Jun 9, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant