Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

214 conditional formatting #227

Merged
merged 52 commits into from
Jun 26, 2022
Merged

214 conditional formatting #227

merged 52 commits into from
Jun 26, 2022

Conversation

jmbarbone
Copy link
Collaborator

resolves #214

@jmbarbone
move bulk of function over
893717c
@jmbarbone
add some notes
cbf758a
@jmbarbone
missed comma
6259e04
@jmbarbone
move conditional formatting examples to vignette
152d40d
@jmbarbone
add test
a57a3a0
@jmbarbone
Merge branch 'main' into 214-conditional-formatting
e618be1
@jmbarbone
update with new function name
c346b99
@jmbarbone
correct params
e7a4472
@jmbarbone
wb_conditional_formatting >> wb$add_conditional_formatting
ecae314
@jmbarbone
use strict match.arg() for conditional formatting type
d19d3d8
@jmbarbone
clean up conditional formatting vignette
d0d09f4
@jmbarbone
use switch() instead of if ... else
79b3fcd
@jmbarbone
redoc
ae389b3
@jmbarbone
use better error message checks
26e88f8
@jmbarbone
add validate_conditional-formatting_params()
0cf151c 
for checking parameters more more easily
@jmbarbone
clean up validations
a425d9d
@jmbarbone
use param params rather than ...
1b990a2
@jmbarbone
reformat documentation
a8f1373
@jmbarbone
redoc
a38f46f
@jmbarbone
formatting
e840dd4
@jmbarbone
correct ... to params
0f8ea08
@jmbarbone
formatting
57bb1dd
@jmbarbone
check for valid expression rule
8fb4aaa
@jmbarbone
spaces
5c4fbf3
@jmbarbone
clean up params
f147f75
@jmbarbone
clean up
d9517aa
@jmbarbone
redoc
d6a59c2
@jmbarbone
showValue not showValues
1caad9f
@jmbarbone
there is no wb param
19f0f8f
@jmbarbone
cleanup param validation
a3cb35c
JanMarvin
JanMarvin reviewed Jun 14, 2022
View reviewed changes
R/class-workbook.R Outdated Show resolved Hide resolved
JanMarvin
JanMarvin reviewed Jun 14, 2022
View reviewed changes
R/utils.R Show resolved Hide resolved
@jmbarbone jmbarbone marked this pull request as ready for review June 15, 2022 03:06
JanMarvin
JanMarvin approved these changes Jun 17, 2022
View reviewed changes
Copy link
Owner

@JanMarvin JanMarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking quite well already!

R/class-workbook.R Show resolved Hide resolved
R/class-workbook.R Show resolved Hide resolved
R/class-workbook.R Outdated Show resolved Hide resolved
R/class-workbook.R Outdated Show resolved Hide resolved
R/helperFunctions.R Show resolved Hide resolved
R/helperFunctions.R Show resolved Hide resolved
vignettes/conditional-formatting.Rmd Show resolved Hide resolved
@JanMarvin
Copy link
Owner

What's the status of this @jmbarbone ? Can it be merged?

@jmbarbone
Copy link
Collaborator Author

I think it's good to merge now. Don't think there's anything pending.

@JanMarvin JanMarvin merged commit 4ea6e3e into main Jun 26, 2022
@JanMarvin
Copy link
Owner

Thanks! Merged.

@JanMarvin JanMarvin deleted the 214-conditional-formatting branch June 26, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanMarvin JanMarvin JanMarvin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up wb_conditional_formatting()
2 participants
@jmbarbone @JanMarvin