remove wb_get_sheet_name
#240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMarvin
commented
Jun 20, 2022
| @@ -3613,7 +3613,7 @@ wbWorkbook <- R6::R6Class( | |||
| ref1 = paste0("$", cols[1]), | |||
| ref2 = paste0("$", cols[2]), | |||
| name = "_xlnm.Print_Titles", | |||
| sheet = names(self)[[sheet]], | |||
| sheet = self$get_sheet_names()[[sheet]], | |||
There was a problem hiding this comment.
Wild guess, but maybe RGui was picking this up?
JanMarvin
commented
Jun 20, 2022
R/class-workbook.R
Outdated
| #' @param index Sheet name index | ||
| #' @return The sheet index | ||
| #' @export | ||
| wb_get_sheet_name = function(wb, index = NULL) { |
There was a problem hiding this comment.
Do we need a deprecated for this, @jmbarbone ?
There was a problem hiding this comment.
I gave up. No need to clean this up right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no real need for this function