Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] remove match from col_to_df() #245

Merged
merged 5 commits into from
Jun 25, 2022
Merged

[c++] remove match from col_to_df() #245

merged 5 commits into from
Jun 25, 2022

Conversation

JanMarvin
Copy link
Owner

@JanMarvin JanMarvin commented Jun 23, 2022

We do not really benefit from these Rcpp functions. Therefore they should be replaced with native c++ or functions we benefit from. This could enable us to build with #include <Rcpp/Lightest>.

  • load_workbook.cpp
  • styles_xml.cpp

@JanMarvin JanMarvin merged commit e289324 into main Jun 25, 2022
@JanMarvin JanMarvin deleted the rm_match branch October 27, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant