[R/write] fixes for NA, NaN, and Inf. Closes #254 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMarvin
commented
Jun 28, 2022
| @@ -503,7 +514,7 @@ write_data2 <-function(wb, sheet, data, name = NULL, | |||
| } | |||
|
|
|||
| sel <- which(dc == openxlsx2_celltype[["character"]]) # character | |||
| for (i in sel) { | |||
| if (length(sel)) { | |||
There was a problem hiding this comment.
this looks pretty stupid to be honest 🤦
JanMarvin
commented
Jun 28, 2022
| ## data | ||
| a <- data.frame( | ||
| A <- data.frame( |
There was a problem hiding this comment.
I assume this test was copied over from openxlsx (at least I hope nobody here uses c as object name) and shortened when we did not support all features. Now that we support more features, we might want to add the missing pieces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the read/write of NA, NaN and Inf. I'm not sure yet if it's a good idea to always convert
#NUM!and/or#VALUE!and maybe more openxml exceptions to R's NaN, NA or Inf. All these exceptions have special meaning in R and must not match their openxml counterparts. I am open to arguments as to why we should or should not do this.