[pugi] print consistency and new format flags to indent attributes #279

JanMarvin · 2022-07-17T11:58:57Z

Related to #231

> txt <- 'abcd\037'
> openxlsx2:::txt_to_si(txt)
[1] "<si><t>abcd</t></si>"
> 
> openxlsx2:::txt_to_is(txt)
[1] "<is><t>abcd</t></is>"
> openxlsx2:::txt_to_is(txt, skip_control = FALSE)
[1] "<is><t>abcd&#31;</t></is>"
> 
> xml_node_create("bar", txt)
[1] "<bar>abcd\037</bar>"

…ing are also used when exporting. This leaves a little less room for customization, but should protect against simple errors. It's unlikely that someone will import with escapes but want to export without. Also, it is now possible to pass arguments to `read_xml()` from functions embedding it.

[pugi] print consistency and new format flags to indent attributes

daed6b7

JanMarvin added the internal 🔧 label Jul 17, 2022

JanMarvin linked an issue Jul 17, 2022 that may be closed by this pull request

replace ASCII control characters #231

Closed

JanMarvin added 4 commits July 17, 2022 14:08

update print pugix_xml doc

2a6f456

Merge branch 'main' into pugi_prints

d2fe854

update NEWS entries

f2f8006

JanMarvin merged commit 695dfe2 into main Jul 19, 2022

JanMarvin deleted the pugi_prints branch July 19, 2022 08:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pugi] print consistency and new format flags to indent attributes #279

[pugi] print consistency and new format flags to indent attributes #279

JanMarvin commented Jul 17, 2022 •

edited

[pugi] print consistency and new format flags to indent attributes #279

[pugi] print consistency and new format flags to indent attributes #279

Conversation

JanMarvin commented Jul 17, 2022 • edited

JanMarvin commented Jul 17, 2022 •

edited