Clean loading #30
Clean loading #30
Conversation
…hey are all straight in a single line like this <a><b><c foo="bar/><b/><c/>.
* don't overwrite existing celXfs with writeData2 (well well, if it isn't my old enemy: me)
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 35.49% 35.71% +0.22%
==========================================
Files 45 45
Lines 10566 10531 -35
==========================================
+ Hits 3750 3761 +11
+ Misses 6816 6770 -46
Continue to review full report at Codecov.
|
R/class-workbook.R
Outdated
|
|
||
| .self$tables <- xml_node_create(xml_name = "table", | ||
| xml_children = c(autofilter, tableColumn, tableStyleXML), | ||
| xml_attributes = table_attrs) |
There was a problem hiding this comment.
It might not look like much, but this is why I'm doing this. Removing weird functions dangling with code in unpredictable manners and replacing them with simple functions that do the heavy lifting behind the scenes.
If one wants a new attribute, just add it to the xml_attributes table. No need to dangle with hundreds of lines of barely readable Rcpp code. And I say that with the greatest respect. Someone has written all that old code and one day someone might look at my code and is like "what the heck is this?" Here we are, taking baby steps everyone :-)
remove a few old unused functions and clean up the loading code a bit more