329 sheet name #331
Merged
329 sheet name #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JanMarvin , I had created an issue long ago (#20) to make these options a bit more visible and well documented (and then I didn't get very far). Something like this can be handled pretty easily and I don't think we'd run into many issues allowing users to specify the default sheet name. |
JanMarvin
approved these changes
Sep 17, 2022
|
Thanks, nice idea! Just one more thing, if I remember correctly there are a few places where I have seen |
* swith paste to paste0 and "Sheet" to "Sheet " * add test for option
|
@jmbarbone , I've pushed a minor modification switching paste for paste0. This way it's possible to use "Sheet" to avoid having whitespace in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #329