Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version #339

Merged
merged 9 commits into from
Sep 30, 2022
Merged

bump version #339

merged 9 commits into from
Sep 30, 2022

Conversation

JanMarvin
Copy link
Owner

@JanMarvin JanMarvin commented Sep 26, 2022 •
edited

  • first submission (26.09.2022)
  • second submission (27.09.2022)
    • reduce package size by converting PNG to JPG files
  • third submission (27.09.2022)
    • use single quotes for external APIs
    • remove all but one donotrun section
    • replace all references to files with temp_xlsx()
    • update copyright in DESCRIPTION and LICENSE
  • fourth submission (29.09.2022)
    • add ggplot2 to Suggests to allow running the wb_add_plot() example
    • remove forgotten set.seed(123) from expect_wrapper()
    • replace commented example from xl_open()

@JanMarvin JanMarvin added this to the v0.3.0 rc2 milestone Sep 26, 2022
@JanMarvin
Copy link
Owner Author

@jmbarbone a submission to CRAN is on the way. I'll merge/update this pull request once they contact me.

@JanMarvin
Copy link
Owner Author

Current main should be in 0.3, guess I forgot to push it here. Otherwise it's just compression of the png files.

@JanMarvin
Convert png to jpg
94e0773
@JanMarvin
update .gitignore
ae06238
@JanMarvin
address CRAN submission comments
89136ce 
* API in single quote in Description
* dontrun -> donttest
* Don't write to user directory when building
* Update Copyrights in Description
@JanMarvin
changes for CRAN submission
634aa29 
* add ggplot2 to Suggests
* remove set.seed from expect-wrapper
* update xl_open example
@JanMarvin
update openxlsx2 man page
4a17e68
@JanMarvin JanMarvin merged commit 756db25 into main Sep 30, 2022
@JanMarvin JanMarvin deleted the 0.3 branch September 30, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.0 rc2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JanMarvin