Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update create_dxfs_style #346

Merged
merged 3 commits into from
Oct 1, 2022
Merged

update create_dxfs_style #346

merged 3 commits into from
Oct 1, 2022

Conversation

JanMarvin
Copy link
Owner

This PR changes the default behavior for create_dxfs_style(). We only create a dxfs style with style information the user requested. Previously we would ship a default font type, font size, font color and background color.

Now this

create_dxfs_style(
  font_color = wb_colour(hex = "FF9C0006"),
  bgFill = wb_colour(hex = "FFFFC7CE")
)

creates this

<dxf>
  <font>
    <color rgb=\"FF9C0006\"/>
  </font>
  <fill>
    <patternFill patternType=\"solid\">
      <bgColor rgb=\"FFFFC7CE\"/>
    </patternFill>
  </fill>
</dxf>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant