Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wbWorkbook] set_bookview #410

Merged
merged 4 commits into from
Dec 1, 2022
Merged

[wbWorkbook] set_bookview #410

merged 4 commits into from
Dec 1, 2022

Conversation

JanMarvin
Copy link
Owner

@JanMarvin JanMarvin commented Nov 9, 2022

Implements setting the bookview with a user friendly helper. See #408

In bookviews it is stated that "[t]here is no limit on the number of workbook views that can be defined for a workbook."

Not sure if we have to address this in the future. For this PR we only assume a single workbookView. Pressumably there can be multiple e.g. the window position can change per sheet.

  • update the default width and height (or can we remove both)?
  • maybe a test?

@JanMarvin JanMarvin added the enhancement 😀 New feature or request label Nov 9, 2022
@JanMarvin JanMarvin added this to the v0.4 milestone Nov 9, 2022
@JanMarvin JanMarvin mentioned this pull request Nov 20, 2022
8 tasks
@JanMarvin JanMarvin merged commit 184a08f into main Dec 1, 2022
@JanMarvin JanMarvin deleted the set_bookview branch December 1, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 😀 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant