Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce fullCalcOnLoad. closes #427 #428

Merged
merged 7 commits into from
Nov 22, 2022
Merged

Enforce fullCalcOnLoad. closes #427 #428

merged 7 commits into from
Nov 22, 2022

Conversation

JanMarvin
Copy link
Owner

@JanMarvin JanMarvin commented Nov 21, 2022

If a formula in a workbook originally created by Excel refers to a cell modified by openxlsx2, the formula was not recalculated when loaded in Excel. The formula was update only if the cell was visited and Enter was hit. This was hard to spot could easily result in errors. This was solved enforcing fullCalcOnLoad.

This also brings revisionPtr simply to reduce visual differences when comparing two files.

@JanMarvin
Copy link
Owner Author

This should be correct, though it is not universally available.

  • Excel simply does nothing without it, works fine with it
  • LibreOffice 7.4 seems to handle it partially. It works on a single sheet, but not with secondary sheets
  • Numbers simply ignores the calculation properties, therefore no issue is visible

@JanMarvin JanMarvin merged commit 7e6076c into main Nov 22, 2022
@JanMarvin JanMarvin deleted the gh_issue_427 branch November 22, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant