Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reading of xml escapes #497

Merged
merged 5 commits into from Dec 27, 2022
Merged

fix reading of xml escapes #497

merged 5 commits into from Dec 27, 2022

Conversation

JanMarvin
Copy link
Owner

@JanMarvin JanMarvin commented Dec 24, 2022

This is ycphs/openxlsx#394 (found it via https://asterhu.com/import-excel-formula-with-ampersand-to-r/)

Could you check if this solves your issue @aster-hu?

  • add test
  • compare speed with internal stringi solution
  • use the faster one in other places as well? if not, why? to much hassle or generally safer?
  • argument, is_xml to skip XML creation ?

@JanMarvin JanMarvin merged commit 0821375 into main Dec 27, 2022
@JanMarvin JanMarvin deleted the more_xml_escapes branch December 27, 2022 10:23
@aster-hu
Copy link

It resolves my issue, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants