cleanups in wb_load #538
Merged
cleanups in wb_load #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in my case the target was a hyperlink ending on a large integer string. guess we don't have to be to careful in this case.
JanMarvin
force-pushed
the
silence_wb_load
branch
from
ab3bcd6
to
b13d2a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this caused NA conversion warnings and was also wrong
I'm seeing
NAs introduced by coercion to integer rangewith a specifically large workbook. This here is not the issue, but I'm not sure what causes this. The workbook looks fine, but it's to large to check everything.