try to avoid passing long xml strings to file.exists() #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows R-devels
file.exists()
does not like our approach of handing down potential XML or file path. I've addedis_xml()
in the if-clause. This should check if thexml
character string is XML content andfile.exists(xml)
should be called only ifxml
is not XML.Still, in this case we will have to parse actual XML strings twice, due to the nature of the
is_xml()
function.Since this error is currently only in Windows R-Devel it might simply be something triggered by current R development. If this ERROR remains over the next couple of days or if CRAN reaches out, we still can merge this or come up with a better idea.