use as_xml_attr() in wb_styles functions. closes #557 #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs some real world testing and might be needed in more cases
This brings behavior changes: empty elements will be treated as missing, they wont be written with
xml_node_create()and are removed from xml strings withxml_mod_attr(). Need to check if this is desired or if there are cases where we do not want this.In
wb_set_selected()we drop additional arguments because they default toNULL. This becomes""withas_xml_attr(NULL)and will be treated as xml node removal inxml_mod_attr(). Previously argumentNULLwould simply be ignored inxml_mod_attr()and we probably should think about cases where we passNULLarguments toxml_mod_attr()