Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy header/footer code #751

Merged
merged 2 commits into from Aug 22, 2023
Merged

copy header/footer code #751

merged 2 commits into from Aug 22, 2023

Conversation

JanMarvin
Copy link
Owner

No description provided.

@olivroy
Copy link
Collaborator

olivroy commented Aug 22, 2023

The wb_add_worksheet() examples now work.

@@ -258,10 +258,10 @@ test_that("test headerFooter", {
# Load workbook and save again
wb2 <- wb_load(tmp1)

expect_equal(wb$worksheets[[1]]$headerFooter,
expect_equal(lapply(wb$worksheets[[1]]$headerFooter, unlist),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is quite ugly, whoever designed these nested lists in the first place gets no cookie today ...

@JanMarvin JanMarvin merged commit 84e518c into main Aug 22, 2023
9 checks passed
@JanMarvin JanMarvin deleted the gh_issue_747_pt2 branch August 22, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants