Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document options #853

Merged
merged 5 commits into from Nov 14, 2023
Merged

Document options #853

merged 5 commits into from Nov 14, 2023

Conversation

olivroy
Copy link
Collaborator

@olivroy olivroy commented Nov 14, 2023

Follow-up to #848., where support for maxWidth and minWidth was added.

Related to #20

@JanMarvin
Copy link
Owner

Thanks @olivroy , looking good! Thanks for fixing my neglect of the getOptions default argument.

olivroy
olivroy commented Nov 14, 2023
View reviewed changes
R/class-comment.R Outdated Show resolved Hide resolved
@JanMarvin
Copy link
Owner

Thanks, just one more thing, could you add minWidth to the code? Guess next to the if widths > getOption(maxWidth) part we might want something like: if widths < getOption("minWidth").

@JanMarvin JanMarvin merged commit f3318f2 into JanMarvin:main Nov 14, 2023
9 checks passed
@JanMarvin
Copy link
Owner

Thanks, merged!

@olivroy olivroy deleted the tweaks branch November 14, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanMarvin JanMarvin JanMarvin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olivroy @JanMarvin