[formulas] allow passing array formula vectors #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMarvin
commented
Feb 24, 2024
JanMarvin
commented
Feb 24, 2024
| attr(dfx, "f_ref") <- dims | ||
| } else { | ||
| rowcols <- dims_to_rowcol(dims) | ||
| ddims <- wb_dims(x = dfx$X, from_col = rowcols[[1]], from_row = as.integer(rowcols[[2]])) |
There was a problem hiding this comment.
@olivroy I was wondering, if we should add something like: wb_dims(from_dim = "A1").
Or even wb_dims(from_dims = "A1:D2") and additional positioning arguments like right, below, top, left. I have quite a few real life cases where I have to position various data frames next to each other on a single sheet, where I could envision this as useful. Might even be a integer argument, so that right = 2 would create a dims range two columns next to the original.
dims <- wb_dims(x = mtcars)
dims
#> "A1:K33"
wb_dims(from_dims = dims, x = mtcars, right = 2)
#> "M1:W33"
wb_dims(from_dims = dims, x = mtcars, below = 2)
#> "A35:K67"
There was a problem hiding this comment.
I can start by doing from_dims!
JanMarvin
commented
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.