-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] add MIP support. closes #979 #983
Conversation
I've improved The sensitivity label applied via MIP (the Microsoft Information Property thingy, see #979) are 7(?) custom text properties. Since there is probably no way for us to write this from scratch, I choose to read the xml string and apply this where required. |
Hi @JanMarvin,
Everything else works as expected. Thanks! |
Thanks for the feedback @retodomax ! Odd that it doesn't work with the options. There is no reason I can think of, why it shouldn't. But maybe I forgot something, I'll have a look later. Could you have a look which of the sections in mips_xlsx looks like a name? I assume there should be something that looks human readable like mips_xml |> as_xml() [EDIT:] In the line below the first returns a mips <- xml_node(xml, "property") %||% getOption("openxlsx2.mips_xml_string") |
Unfortunately, there is nothing like
and it continues with |
Thanks! Guess, as long as it works it does not have to bother us, but in this case I can disable the message. It should be used so that somebody how has multiple MIPS sections available, can differentiate them, but I doubt that anybody understands these digits. It looks like they match your organizations MIPS string (from your example above, I've added <property fmtid="{D5CDD505-...AE}" pid="5" name="MSIP_Label_**1c79e38c-78...05**_Name">
<vt:lpwstr>**1c79e38c-78...05**</vt:lpwstr>
</property> Two additional observations:
|
Hi @JanMarvin
|
…nsions. It's now possible to create them using a named list and wb_add_mips() is just a special feature using this code
Hi @retodomax , thanks for the testing! Guess it is good to go now. |
TODO list
Maybe you can have a look at this PR @retodomax
It's still WIP, but this should be a start. I only have this single file to play around with (it's from this issue: OfficeDev/office-js#2459) and as stated no way to test if it works. My only test is that the output opens in MS365, but there is no MIP banner for me.
[EDIT] updated code snippet above