84 expect wrapper #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #86
* changes names to `old` and `new` to be more explicit * removing use of \" for escaping double-quotes and just wrapping in single quotes * some formatting
* remove showStyle field -- no need to have this * hey, make sure the style actually shows something * clean out some names
* add family tag * remove redundant tags * group tags better (like grouping)
maybe changes a bit too much (related to #91)
Merged
|
Yay, everything's green! is this ready for review? |
A rarity that something I did actually increased codecov! Yes, ready for review. |
|
Alright, I will begin with that Monday afternoon (traveling for the weekend). Guess all my nitpicking can be solved after merging, but I'm keen to understand your changes! |
JanMarvin
approved these changes
Apr 18, 2022
| stop(msg, call. = FALSE) | ||
| } | ||
|
|
||
|
|
||
| which(replaceXMLEntities(wb$sheet_names) == sheetName) | ||
| which(replaceXMLEntities(wb$sheet_names) == sheet) |
There was a problem hiding this comment.
the wb_create_font_node() below was already removed in main iirc.
|
looks good to me! feel free to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #82
resolves #86