Use more C++ features #18
Conversation
- Use C++ style for structs, including constructors, destructors - Use C++ new/delete instead of malloc()/free() - Use C++ initializer list for constructors - Use templates to avoid some copy&paste code - Atom and functor static constants moved inside functions that use them - Add [[nodiscard]]s - Class PlSlice is encpasulates rocksdb::Slice instead of subclassing it - Remove some inappropriate uses of PlCheckFail()
|
This code needs to be tested using ASAN. (The old code hasn't been tested under ASAN either, as far as I know) |
kamahen
force-pushed
the
codereview2
branch
4 times, most recently
from
a1cbae2
to
d0a54b9
Compare
- Move dbref cleanup code to destructor - Fix rocks_close/1 cleanup - Add acquire_rocks_ref() for consistent handling of dbref::symbol - Simplify error handling cleanup by using unique_ptr - Fix some potential memory/resource leaks Dbref blob save/load gives an error Added some "consts"; changed some pointers to references Added rocks_alias_lookup/2
- avoids needing to analyze lifetime of dbref pointer in rocks_open/3.
- Do all blob casts through cast_dbref_blob() - PL_BLOB_NOCOPY and no default copy constructors Changed some const pointers to const references Standadized some parameter names
kamahen
force-pushed
the
codereview2
branch
2 times, most recently
from
3d258eb
to
b3d6953
Compare
- Some of the code will go to SWI-cpp2.h (and documentation to pl2cpp2.doc). - Documentation needs improvement. - Need to add a few more tests (especially error handling) and test with ASAN.
|
Ready for final review. Merging this will need to be coordinated with changes to SWI-cpp2.h ... there's a section of rocksdb4pl.cpp that should move to SWI-cpp2.h. (It would be nice if there were a way of specifying the minimum swipl version) The version number in pack.pl probably should be 0.14.0 because there have been some small semantic changes (e.g., getting rid of the "once" option. But most of the changes have been in making the code less C-like and more C++-like, including taking advantage of new features in SWI-cpp2.h. |
|
The code requires the latest changes in SWI-Prolog/packages-cpp#47 |
|
The latest changes require SWI-Prolog/packages-cpp#49 |
|
Works fine! |
These changes were found by doing a code-review, which is why they aren't in separate, smaller PRs.
This PR also fixes an incomplete cherry-pick for PlSlice.