plugin: new channel API #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'system' channel to send 'pause' and 'resume' events to node. Add 'events' to the channel to allow user defined events. Allow user defined objects to be sent through the channel.
Add documentation for the channel API changes.
Adds app.datadir to the bridge to access a writable persistent path from the nodejs-mobile runtime, which should be the FilesDir on Android and the NSDocumentDirectory on iOS. Also sets the os.tmpdir() to the CacheDir on Android.
Messages sent to the node runtime with values that evaluate as false in conditions were reaching node as undefined value. Fixes this behavior so that only undefined values can reach node.
Waits for the pause event handler to finish before letting the iOS application suspend after going to the background. Passes a pauseLock object to the pause event handlers to release so the app channel can signal the application it can suspend.
orangemocha
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to the plugin's APIs:
os.tmpdir()will now return the application's cache directory on Android.