Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to support Cordova 9. #7

Closed
wants to merge 1 commit into from

Conversation

hanieel
Copy link

@hanieel hanieel commented Aug 7, 2019

The use of context.requireCordovaModule for non-cordova dependencies has been removed use 'require' instead. Cordova Dropped the use of 'Q' Dependency use Native Promises instead.

… non-cordova dependencies has been removed use 'require' instead. Cordova Dropped the use of 'Q' Dependency use Native Promises instead.
@jaimecbernardo
Copy link
Member

Hi @hanieel ,

Thank you for this contribution.
Keeping support for older versions is desirable, so I've opened a PR to your branch to communicate the needed changes: hanieel#1

I'd be happy to accept the PR once those changes are in, or support to Cordova 7 and 8 is kept through other means.

@jaimecbernardo
Copy link
Member

Hi, Ended up merging these changes with the fixes needed for keeping support for older versions: 72ede37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants