android: ensure dir.list and file.list are ordered similarly across builds #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilds Created dir_list_arr and file_list_arr in the GenerateNodeProjectAssetsLists task to sort accordingly before passing it off to file_list and dir_list.
|
LGTM! Thank you for the contribution. |
softdevjs7
added a commit
to softdevjs7/nodejs-mobile-react-native
that referenced
this pull request
Sep 30, 2022
Sorts dir.list and file.list. This makes sure the app is reproducible between builds. PR-URL: JaneaSystems/nodejs-mobile-react-native#16 Reviewed-By: Jaime Bernardo <jaime@janeasystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix helps to ensure the app is reproducible across builds.
Created dir_list_arr and file_list_arr in the GenerateNodeProjectAssetsLists task to sort accordingly before passing it off to file_list and dir_list.