feat: support cancel request (#3733)

Co-authored-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
JanssenProject · Jan 31, 2023 · 2741e51 · 2741e51
1 parent f342c7e
commit 2741e51
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...server/src/main/java/io/jans/fido2/service/sg/converter/AssertionSuperGluuController.java b/...server/src/main/java/io/jans/fido2/service/sg/converter/AssertionSuperGluuController.java
@@ -10,8 +10,11 @@
 import java.nio.ByteBuffer;
 import java.nio.charset.StandardCharsets;
 
+
+import org.apache.commons.lang3.ArrayUtils;
 import org.slf4j.Logger;
 
+
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.node.ArrayNode;
 import com.fasterxml.jackson.databind.node.ObjectNode;
@@ -165,7 +168,7 @@ public JsonNode finishAuthentication(String userName, String authenticateRespons
             throw new Fido2RpRuntimeException("Failed to parse options assertion request", ex);
         }
 
-        if (!authenticateResponse.getClientData().getTyp().equals(RawAuthenticationService.AUTHENTICATE_GET_TYPE)) {
+        if (!ArrayUtils.contains(RawAuthenticationService.SUPPORTED_AUTHENTICATE_TYPES, authenticateResponse.getClientData().getTyp())) {
             throw new Fido2RuntimeException("Invalid options attestation request type");
         }
 

diff --git a/...rver/src/main/java/io/jans/fido2/service/sg/converter/AttestationSuperGluuController.java b/...rver/src/main/java/io/jans/fido2/service/sg/converter/AttestationSuperGluuController.java
@@ -11,6 +11,7 @@
 import java.nio.charset.Charset;
 import java.security.cert.CertificateEncodingException;
 
+import org.apache.commons.lang3.ArrayUtils;
 import org.slf4j.Logger;
 
 import com.fasterxml.jackson.databind.JsonNode;
@@ -194,7 +195,7 @@ public JsonNode finishRegistration(String userName, String registerResponseStrin
             throw new Fido2RpRuntimeException("Failed to parse options attestation request", ex);
         }
 
-        if (!registerResponse.getClientData().getTyp().equals(RawRegistrationService.REGISTER_FINISH_TYPE)) {
+        if (!ArrayUtils.contains(RawRegistrationService.SUPPORTED_REGISTER_TYPES, registerResponse.getClientData().getTyp())) {
             throw new Fido2RuntimeException("Invalid options attestation request type");
         }