fix: don't execute next paged search if current result count less than (

#2171) allowed row count Co-authored-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
JanssenProject · Aug 18, 2022 · 94a162f · 94a162f
1 parent 8ec5dd3
commit 94a162f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/...ase/src/main/java/io/jans/orm/couchbase/operation/impl/CouchbaseOperationServiceImpl.java b/...ase/src/main/java/io/jans/orm/couchbase/operation/impl/CouchbaseOperationServiceImpl.java
@@ -518,7 +518,7 @@ private <O> PagedResult<JsonObject> searchImpl(BucketMapping bucketMapping, Stri
 
 	            StringBuilder query = null;
 	            int currentLimit;
-	            int lastResultCount = 0;
+	            int lastCountRows = 0;
 	            try {
 	                List<JsonObject> lastSearchResultList;
 					do {
@@ -539,26 +539,26 @@ private <O> PagedResult<JsonObject> searchImpl(BucketMapping bucketMapping, Stri
 	    	            }
 
 	                    lastSearchResultList = lastResult.rowsAsObject();
-		                lastResultCount = lastSearchResultList.size();
+		                lastCountRows = lastSearchResultList.size();
 
 	                    if (batchOperation != null) {
-	                        collectSearchResult = batchOperation.collectSearchResult(lastResultCount);
+	                        collectSearchResult = batchOperation.collectSearchResult(lastCountRows);
 	                    }
 	                    if (collectSearchResult) {
 	                        searchResultList.addAll(lastSearchResultList);
 	                    }
 
-	                    if ((batchOperation != null) && (lastResultCount > 0)) {
+	                    if ((batchOperation != null) && (lastCountRows > 0)) {
 	                        List<O> entries = batchOperationWraper.createEntities(lastSearchResultList);
 	                        batchOperation.performAction(entries);
 	                    }
 
-	                    totalEntriesCount += lastResultCount;
+	                    totalEntriesCount += lastCountRows;
 
-	                    if ((count > 0) && (totalEntriesCount >= count)) {
+	                    if ((count > 0) && (totalEntriesCount >= count) || (lastCountRows < currentLimit)) {
 	                        break;
 	                    }
-	                } while (lastResultCount > 0);
+	                } while (lastCountRows > 0);
 	            } catch (CouchbaseException ex) {
 	                throw new SearchException("Failed to search entries. Query: '" + query + "'", ex);
 	            }

diff --git a/...r/src/main/java/io/jans/orm/cloud/spanner/operation/impl/SpannerOperationServiceImpl.java b/...r/src/main/java/io/jans/orm/cloud/spanner/operation/impl/SpannerOperationServiceImpl.java
@@ -653,7 +653,7 @@ private <O> PagedResult<EntryData> searchImpl(TableMapping tableMapping, String
 
 	                    resultCount += lastCountRows;
 
-	                    if ((count > 0) && (resultCount >= count)) {
+	                    if ((count > 0) && (resultCount >= count) || (lastCountRows < currentLimit)) {
 	                        break;
 	                    }
 	                } while (lastCountRows > 0);