fix(jans-auth-server): validate redirect_uri blank and client redirec…

…t uris single item to return by default (#1046)
JanssenProject · Mar 15, 2022 · aa139e4 · aa139e4
1 parent 4d93a49
commit aa139e4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/jans-auth-server/server/src/main/java/io/jans/as/server/service/RedirectionUriService.java b/jans-auth-server/server/src/main/java/io/jans/as/server/service/RedirectionUriService.java
@@ -106,7 +106,7 @@ public String validateRedirectionUri(@NotNull Client client, String redirectionU
                 redirectUris = getSectorRedirectUris(sectorIdentifierUri).toArray(new String[0]);
             }
 
-            if (StringUtils.isBlank(sectorIdentifierUri) && redirectUris != null && redirectUris.length == 1) {
+            if (StringUtils.isBlank(redirectionUri) && redirectUris != null && redirectUris.length == 1) {
                 return redirectUris[0];
             }
 

diff --git a/...auth-server/server/src/test/java/io/jans/as/server/service/RedirectionUriServiceTest.java b/...auth-server/server/src/test/java/io/jans/as/server/service/RedirectionUriServiceTest.java
@@ -95,6 +95,16 @@ public void validateRedirectionUri_sectorIdentifierBlankAndRredirectUrlNull_retu
         assertNull(returnValue);
     }
 
+    @Test
+    public void validateRedirectionUri_redirectionUriBlankAndOneClientRedirectUri_returnSingleItem() {
+        final String singleRedirectUri = "https://client.example.com/cb2";
+        final Client client = getClientForValidateRedirectionUri_sectorIdentifierBlank_redirectURisNull();
+        client.setRedirectUris(new String[]{ singleRedirectUri });
+
+        final String returnValue = redirectionUriService.validateRedirectionUri(client, singleRedirectUri);
+        assertEquals(singleRedirectUri, returnValue);
+    }
+
     private Client getClientForValidateRedirectionUri_full() {
         final Client client = new Client();
         client.setSectorIdentifierUri("https://test.gluu.org/jans-auth/sectoridentifier/a55ede29-8f5a-461d-b06e-76caee8d40b5");

diff --git a/jans-linux-setup/jans_setup/templates/jans-auth/jans-auth-config.json b/jans-linux-setup/jans_setup/templates/jans-auth/jans-auth-config.json
@@ -446,5 +446,5 @@
     "deviceAuthzRequestExpiresIn": 1800,
     "deviceAuthzTokenPollInterval": 5,
     "deviceAuthzResponseTypeToProcessAuthz": "code",
-    "redirectUrisRegexEnabled": false
+    "redirectUrisRegexEnabled": true
 }