Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(jans-auth-server): refactor AuthorizeRestWebServiceImpl #1208

Closed
yuriyz opened this issue Apr 18, 2022 · 1 comment
Closed

refactor(jans-auth-server): refactor AuthorizeRestWebServiceImpl #1208

yuriyz opened this issue Apr 18, 2022 · 1 comment
Assignees
@yuriyz
Labels
comp-jans-auth-server Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Apr 18, 2022

Description

Over years authorization logic in AS for authz growth in AuthorizeRestWebServiceImpl with ~1250 lines of code. Code complexity of main authz method is 207 instead of recommended 15. It is going towards maintanence problem.

image
@yuriyz yuriyz added kind-enhancement Issue or PR is an enhancement to an existing functionality comp-jans-auth-server Component affected by issue or PR labels Apr 18, 2022
@yuriyz yuriyz self-assigned this Apr 18, 2022
yuriyz added a commit that referenced this issue Apr 19, 2022
@yuriyz
feat(jans-auth-server): added authzrequest abstraction
af8faf0 
#1208
@yuriyz yuriyz mentioned this issue Apr 19, 2022
Closed
@yuriyzz yuriyzz mentioned this issue Apr 19, 2022
Merged
yuriyz added a commit that referenced this issue Apr 20, 2022
@yuriyz
feat(jans-auth-server): adapted authorization ws to use authzrequest
58c5336 
#1208
yuriyz added a commit that referenced this issue Apr 22, 2022
@yuriyz
refactor(jans-auth-server): keep authzrequest as single source of red…
d7da21a 
…irect info

#1208
@yuriyzz yuriyzz mentioned this issue Apr 22, 2022
Merged
yuriyz added a commit that referenced this issue Apr 25, 2022
@yuriyz
refactor(jans-auth-server): added authz request service
4d5ad26 
#1208
@yuriyzz yuriyzz mentioned this issue Apr 25, 2022
Merged
yuriyz added a commit that referenced this issue Apr 26, 2022
@yuriyz
refactor(jans-auth-server): moved acr validation to validator
cd22f19 
#1208
@yuriyzz yuriyzz mentioned this issue Apr 26, 2022
Merged
yuriyz added a commit that referenced this issue Apr 27, 2022
@yuriyz
refactor(jans-auth-server): extracted request object processing into …
ae0b60b 
…separate method

#1208
@yuriyzz yuriyzz mentioned this issue Apr 27, 2022
Merged
yuriyz added a commit that referenced this issue Apr 28, 2022
@yuriyz
refactor(jans-auth-server): extracted user and response parameters ha…
e30e65e 
…ndling into separate methods during authz

#1208
@yuriyzz yuriyzz mentioned this issue Apr 28, 2022
Merged
yuriyz added a commit that referenced this issue May 2, 2022
@yuriyz
refactor(jans-auth-server): extracted common functions
bfc5384 
#1208
@yuriyzz yuriyzz mentioned this issue May 2, 2022
Merged
@yuriyz
Copy link
Contributor Author

yuriyz commented May 11, 2022

All sonar issues in AuthorizeRestWebServiceImpl were fixed. Along the way added new AuthzRequest and corresponding AuthzRequestService abstraction which simplified code a lot and allowed to drop gigantic 207 cognitive complexity method.

@yuriyz yuriyz closed this as completed May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuriyz