Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(jans-auth-server): half of tests are in failed state after jetty 11 migration #1341

Closed
yuriyz opened this issue May 16, 2022 · 1 comment
Assignees
Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality priority-0 Causes full outage, breakage, or major function unavailability for everyone, without a workaround.

Comments

@yuriyz
Copy link
Contributor

yuriyz commented May 16, 2022

Describe the bug

Half of tests are in failed state after jetty 11 migration. Why didn't we see it before ? Because somebody disabled them manually !

https://jenkins.jans.io/jenkins/job/jans-auth-server/6383/testngreports/

image

@yuriyz yuriyz added kind-bug Issue or PR is a bug in existing functionality comp-jans-auth-server Component affected by issue or PR priority-0 Causes full outage, breakage, or major function unavailability for everyone, without a workaround. labels May 16, 2022
@yuriyz yuriyz self-assigned this May 16, 2022
yuriyz added a commit that referenced this issue May 16, 2022
Corrected serialization and deserialization of RegisterRequest list fields.

#1341
yuriyz added a commit that referenced this issue May 17, 2022
#1354)

* fix(jans-auth-server): restored previous state of authz impl

#1341

* fix(jans-auth-server): cherry-pick 4d5ad26 and adapt code

#1341

* fix(jans-auth-server): cherry-pick ae0b60b and adapt code

#1341

* fix(jans-auth-server): cherry-pick e30e65e and adapt code

#1341

* Revert "fix(jans-auth-server): cherry-pick e30e65e and adapt code"

This reverts commit f3c6bd7.

* Revert "fix(jans-auth-server): cherry-pick ae0b60b and adapt code"

This reverts commit 5e6e939

* fix(jans-auth-server): put back inlined request jwt

* fix(jans-auth-server): extracted authorize method

* fix(jans-auth-server): more extracted methods out of authorize

* fix(jans-auth-server): extracted methods out of authorize

* fix(jans-auth-server): methods out of authorize

* fix(jans-auth-server): request jwt refactoring

* fix(jans-auth-server): corrected redirect uri creation

* fix(jans-auth-server): corrected redirect uri creation

* fix(jans-auth-server): corrected register response assert builder

* fix(jans-auth-server): code clean up

Co-authored-by: YuriyZ <yzabrovarniy@gmail.com>
@yuriyz
Copy link
Contributor Author

yuriyz commented May 18, 2022

All client side tests are passed now. We still have problem with server side integration tests. But it is investigated by @Milton-Ch as part of #1247

Closing this ticket.

https://jenkins.jans.io/jenkins/job/jans-auth-server/6438/

image

@yuriyz yuriyz closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality priority-0 Causes full outage, breakage, or major function unavailability for everyone, without a workaround.
Projects
None yet
Development

No branches or pull requests

1 participant