Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jans-cli: Optional fields should be sorted or categorised so that options are easy to locate #1349

Closed
ossdhaval opened this issue May 17, 2022 · 1 comment · Fixed by #2429
Closed

jans-cli: Optional fields should be sorted or categorised so that options are easy to locate #1349

ossdhaval opened this issue May 17, 2022 · 1 comment · Fixed by #2429
Labels
comp-jans-cli-tui Component affected by issue or PR effort-2 Relative effort required for completion of issue or PR good first issue Good for newcomers help wanted Extra attention is needed kind-enhancement Issue or PR is an enhancement to an existing functionality priority-5 Issue or PR addresses a very minor concern. Not planned for active development. Will not be fixed.
Milestone
1.0.3

Comments

@ossdhaval
Copy link
Contributor

ossdhaval commented May 17, 2022 •
edited
Loading

This refers to usability issue in jans-cli.

While using certain operations, like for example manually registering new OIDC client, jans-cli takes in few default params and then asks for optional parameters.

Issue one:
Optional fields list should be sorted or categorised so that options are easy to locate. As shown in image below, optional fields presents a huge list of optional fields. If you are looking for a particular option, it is not easy to find. For example, if it was sorted in alphabetical order, it would be easy. Or may be categorised in some logical way.

image

Minor second issue:
the Populate optional fields? doesn't have any suggestions for input.
image

Originally posted by @ossdhaval in #1158 (comment)
@mo-auto mo-auto added the comp-jans-cli-tui Component affected by issue or PR label May 17, 2022
@ossdhaval ossdhaval added kind-enhancement Issue or PR is an enhancement to an existing functionality good first issue Good for newcomers effort-2 Relative effort required for completion of issue or PR priority-5 Issue or PR addresses a very minor concern. Not planned for active development. Will not be fixed. labels May 17, 2022
@ossdhaval ossdhaval added the help wanted Extra attention is needed label May 17, 2022
@moabu moabu added this to the 1.0.1 milestone Jun 15, 2022
@moabu moabu modified the milestones: 1.0.1, 1.0.2 Jul 8, 2022
@moabu moabu modified the milestones: 1.0.2, 1.0.3 Aug 30, 2022
devrimyatar added a commit that referenced this issue Sep 21, 2022
@devrimyatar
fix: jans-cli sort optional fields (ref: #1349)
7a2683b
@devrimyatar devrimyatar mentioned this issue Sep 21, 2022
Merged
@devrimyatar
Copy link
Contributor

devrimyatar commented Sep 21, 2022 •
edited
Loading

In commit 7a2683b, optional fields are sorted:
image

yuriyz pushed a commit that referenced this issue Sep 28, 2022
@devrimyatar
fix: jans-cli fixes (#2429)
c9673dc 
* fix: jans-cli client clientName

* fix: jans-cli config-api pagination

* fix: jans-cli seperation char (ref: #1350)

* fix: jans-cli identify if patch property is array

* fix: jans-cli sort optional fields (ref: #1349)

* fix: jans-cli add log_dir to ini file and arg (ref: #1655)

* fix: jans-cli _b for escaping prompt (ref: #1657)

* feat: jans-cli tabulate UMA Resources

* fix: jans-cli array values for patch (ref: #1753)

* fix: jans-cli display last item in tabulated data

* fix: jans-cli item numbers in tabulated data

* fix: jans-cli hide user operations for openbanking (ref: #1878)

* fix: jans-cli hide fido2 for openbanking (ref: #1911)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp-jans-cli-tui Component affected by issue or PR effort-2 Relative effort required for completion of issue or PR good first issue Good for newcomers help wanted Extra attention is needed kind-enhancement Issue or PR is an enhancement to an existing functionality priority-5 Issue or PR addresses a very minor concern. Not planned for active development. Will not be fixed.
Projects
None yet
Milestone
1.0.3
Development

Successfully merging a pull request may close this issue.

fix: jans-cli fixes JanssenProject/jans
4 participants
@ossdhaval @devrimyatar @moabu @mo-auto