Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agama): reject usage of repeated input names #1440

Closed
jgomer2001 opened this issue May 23, 2022 · 0 comments
Closed

feat(agama): reject usage of repeated input names #1440

jgomer2001 opened this issue May 23, 2022 · 0 comments
Assignees
@jgomer2001
Labels
kind-feature Issue or PR is a new feature request

Comments

@jgomer2001
Copy link
Contributor

jgomer2001 commented May 23, 2022 •
edited
Loading

Transpiler must be updated so it is required all input names are different (including the variable used for binding config properties).

Currently this is being accepted

Flow my.qname
    Basepath ""
    Conf x
    Inputs x x x ...
...
@jgomer2001 jgomer2001 self-assigned this May 23, 2022
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label May 23, 2022
jgomer2001 added a commit that referenced this issue May 31, 2022
@jgomer2001
chore: minor updates #1440
ff95268
jgomer2001 added a commit that referenced this issue May 31, 2022
@jgomer2001
feat: add checks to ensure uniqueness in flow parameters #1440
96e3411
@jgomer2001 jgomer2001 mentioned this issue May 31, 2022
Merged
yuriyz pushed a commit that referenced this issue May 31, 2022
@jgomer2001
feat(agama): reject usage of repeated input names (#1484)
aed8cf3 
* chore: minor updates #1440

* feat: add checks to ensure uniqueness in flow parameters #1440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgomer2001 jgomer2001

Labels
kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgomer2001 @mo-auto