Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-config-api): agama flow endpoint #1898

Merged
merged 29 commits into from
Jul 29, 2022
Merged

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Jul 27, 2022

Prepare


Description

New service for agama flows to fetch, create, update and delete agama flows

Target issue

closes #1509

Implementation Details

Agama endpont:

  1. /jans-config-api/api/v1/agama
    GET - Fetches all the flow
    POST - Create a new flow

  2. /jans-config-api/api/v1/agama/{qname}
    GET - Fetch flow based on qname
    POST - Create a flow with request payload reading source file
    PUT - Updates a flow based on qname
    DELETE - Deletes a flow

Agama: ProtoFlow.java is modified to change field name from QName to qname
And related change in agama code for the same
Setup: Changes to jans-config-api config template to add agama related config properties.


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Closes #1904,

pujavs added 25 commits July 19, 2022 14:09
@mo-auto
Copy link
Member

mo-auto commented Jul 27, 2022

Error: Hi @pujavs, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto
Copy link
Member

mo-auto commented Jul 27, 2022

Error: Hi @pujavs, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto
Copy link
Member

mo-auto commented Jul 27, 2022

Error: Hi @pujavs, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

[agama parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pujavs
Copy link
Contributor Author

pujavs commented Jul 29, 2022

@yuriyz, @jgomer2001 and @devrimyatar request you to please review and approve the changes related to agama endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-agama Touching folder /agama comp-jans-config-api Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
5 participants