-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jans-config-api): improvements to existing agama endpoints and create PUT for code only #1982
Comments
Creation
should be fields. The same goes for PUT
but it should contain the
|
Modification
Sending this payload: gives Using this payload:
throws internal server error. Here are the logs: |
Testing: Feedback implementation testing evidence Note for:
|
Increasing jansRevision by 1 at every call here was a good decision, thanks. However you are also updating metadata/timestamp. This is a creation timestamp so there is no need to alter this property If the flow has Desired behavior is to alter
Every time this endpoint is called, revision and timestamp are refreshed automatically. This is not desired. If the caller wants to explicitly supply values for them, they can be updated. Some properties are lost as in the previous case (PUT) Desired behavior is to alter only the data sent in the patch
can you call |
Retrieval
Currently GETting all flows (
/jans-config-api/api/v1/agama
) returns all attributes; it should return fewer as mentioned here. Also, let's make single flow retrieval behave the same, ie. not outputing all attributes.In some cases, one may like to have
source
in the output as well. Let's include it if a given request parameter is present, like/jans-config-api/api/v1/agama?includeSource
. Applies for both GET endpointsThe text was updated successfully, but these errors were encountered: