Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config-api): swagger spec changes for session, properties endpoint and ignoring customobject for non LDAP DB #2348

Merged
merged 13 commits into from
Sep 9, 2022
Merged

fix(config-api): swagger spec changes for session, properties endpoint and ignoring customobject for non LDAP DB #2348

merged 13 commits into from
Sep 9, 2022

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Sep 9, 2022 •
edited
Loading

Prepare

Description

Target issue

closes #2339 #2345 #2350

Implementation Details

Changes:

  1. Swagger spec
    1.1) session: rectification for for security scope and enum value
    1.2) auth config: synching change in spec for auth server config for AuthorizationRequestCustomParameter
  2. user management plugin: changes to ignore custom object changed of non LDAP DB
  3. scim plugin: changes to use scim config model

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@pujavs
feat(jans-config-api): spanner paged result issue 2139
cc35b0a
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
7d0b58f 
…ns-config-api-fixes
@pujavs
fix(config-api): rectified search filter logic for attribute resource
ede1639
@pujavs
Merge branch 'jans-config-api-fixes' of https://github.com/JanssenPro…
af9932e 
…ject/jans into jans-config-api-fixes
@pujavs
fix(config-api): rectified search filter logic for attribute resource
e2eb331
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
8ecbbe0 
…ns-config-api-fixes
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
ad7890f 
…ns-config-api-fixes
@pujavs
bug(config-api): swagger spec rectification for session endpoint and …
69b13d9 
…custom object changed of non LDAP DB
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
251c994 
…ns-config-api-fixes
@pujavs
feat(config-api): changes for synching change in auth server config f…
e6a4d5c 
…or AuthorizationRequestCustomParameter
@pujavs pujavs requested a review from yuriyz as a code owner September 9, 2022 15:56
yuriyz
yuriyz previously approved these changes Sep 9, 2022
View reviewed changes
@yuriyz
Copy link
Contributor

yuriyz commented Sep 9, 2022

@pujavs merge main into your branch to resolve conflict.

@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2022

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Sep 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pujavs
Copy link
Contributor Author

pujavs commented Sep 9, 2022

@yuriyz, i have fixed the merge conflict

@yuriyz yuriyz merged commit c6acaac into main Sep 9, 2022
@yuriyz yuriyz deleted the jans-config-api-fixes branch September 9, 2022 18:47
This was referenced Sep 12, 2022
Closed
Closed
@mo-auto mo-auto mentioned this pull request Nov 1, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(config-api): session endpoints giving error for Insufficient scopes inspite of having the correct one
3 participants
@pujavs @yuriyz @mo-auto