Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans): OpenID Client and Users CustomAttribute should return appropriate attribute type #2483

Closed
pujavs opened this issue Sep 27, 2022 · 4 comments · Fixed by #2510 or #2585
Closed
Assignees
Labels
kind-feature Issue or PR is a new feature request
Milestone

Comments

@pujavs
Copy link
Contributor

pujavs commented Sep 27, 2022

Currently CustomAttributes for OpenID Client and Users return type as String.
Need changes to return appropriate CustomAttribute type

This would involve change in various modules including config-api

@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Sep 27, 2022
@moabu
Copy link
Member

moabu commented Sep 28, 2022

Created from a chat thread internally

@moabu moabu added this to the 1.0.3 milestone Sep 29, 2022
@pujavs
Copy link
Contributor Author

pujavs commented Sep 29, 2022

@yuriyz and @yurem, regarding replacing CustomAttribute with CustomObjectAttribute in User and Client models,

  1. User: User class already is using CustomObjectAttribute. Refer https://github.com/JanssenProject/jans/blob/main/jans-orm/model/src/main/java/io/jans/orm/model/base/SimpleUser.java#L43

  2. Client: However we will need to change Client model. Refer https://github.com/JanssenProject/jans/blob/main/jans-auth-server/common/src/main/java/io/jans/as/common/model/registration/Client.java#L193

@yuriyz
Copy link
Contributor

yuriyz commented Sep 29, 2022

I will change Client on AS side to use CustomObjectAttribute.

@yuriyz
Copy link
Contributor

yuriyz commented Sep 30, 2022

Changes on AS side are done in #2510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind-feature Issue or PR is a new feature request
Projects
None yet
5 participants