Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-api): client default value handling #2585

Merged
merged 11 commits into from
Oct 11, 2022
Merged

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Oct 11, 2022

Prepare


Description

Target issue

closes #2483

Implementation Details

Client Resource: handled default values for client creation
Auth Server: App configuration, changed the getter method for one of the boolean attribute to fix patch that was not working. Jackson depends on Java Bean naming conventions with their accessors (getters) and mutators (setters). Will have to implement this change for all boolean attributes

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(jans): OpenID Client and Users CustomAttribute should return appropriate attribute type
2 participants