Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (jans-linux-setup): disable github authentication and interception scripts by default and other changes. #3022

Closed
duttarnab opened this issue Nov 17, 2022 · 0 comments · Fixed by #3023
Closed

fix (jans-linux-setup): disable github authentication and interception scripts by default and other changes. #3022

duttarnab opened this issue Nov 17, 2022 · 0 comments · Fixed by #3023
Assignees
@duttarnab
Labels
comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@duttarnab
Copy link
Contributor

  • The GitHub authentication and interception scripts should not be enabled by default.

  • the github.json file which has credentials and other properties of github OAuth App should have the location /etc/jans/conf/github.json.
@duttarnab duttarnab added kind-bug Issue or PR is a bug in existing functionality comp-jans-linux-setup Component affected by issue or PR labels Nov 17, 2022
@duttarnab duttarnab self-assigned this Nov 17, 2022
duttarnab added a commit that referenced this issue Nov 17, 2022
@duttarnab
fix: disable github authentication and interception scripts by defaul…
e0191df 
…t and other changes. #3022
@duttarnab duttarnab mentioned this issue Nov 17, 2022
Merged
yuriyz pushed a commit that referenced this issue Nov 17, 2022
@duttarnab
fix: disable github authentication and interception scripts by defaul…
13f5998 
…t and other changes. #3022 (#3023)
This was referenced Dec 1, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duttarnab duttarnab

Labels
comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
1 participant
@duttarnab