Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jans-cli nested list in Properties #3062

Closed
devrimyatar opened this issue Nov 23, 2022 · 1 comment
Closed

fix: jans-cli nested list in Properties #3062

devrimyatar opened this issue Nov 23, 2022 · 1 comment
Assignees
@AbdelwahabAdam
Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@devrimyatar
Copy link
Contributor

Describe the bug
Editing a nested list in Properties, for example, responseTypesSupported in the following screenshot

image

raises error:

  File "/mnt/data/projects/Janssen/jans/jans-cli-tui/cli_tui/plugins/010_oxauth/view_property.py", line 204, in prepare_properties
    value='\n'.join(self.value),

Exception sequence item 0: expected str instance, list found

To Reproduce
Steps to reproduce the behavior:

  1. Execute TUI
  2. Navigate to Properties tab of Auth Server,
  3. Click Next couple of times untill you see property responseTypesSupported, press Enter
@devrimyatar devrimyatar added kind-bug Issue or PR is a bug in existing functionality comp-jans-cli-tui Component affected by issue or PR labels Nov 23, 2022
@AbdelwahabAdam
Copy link
Contributor

AbdelwahabAdam commented Nov 24, 2022 •
edited
Loading

Solved and revised all array type properties:

Property Name Type Output type Widget implemented Editable
subjectIdentifiersPerClientSupported Array List of values TexrArea ✔️
responseTypesSupported Array List of Lists checkboxlist ✔️
responseModesSupported Array List of values checkboxlist ✔️
grantTypesSupported Array List of values checkboxlist ✔️
subjectTypesSupported Array List of values TexrArea ✔️
authorizationSigningAlgValuesSupported Array List of values TextArea ✔️
authorizationEncryptionAlgValuesSupported Array List of values TextArea ✔️
authorizationEncryptionEncValuesSupported Array List of values TextArea ✔️
userInfoSigningAlgValuesSupported Array List of values TextArea ✔️
userInfoEncryptionAlgValuesSupported Array List of values TextArea ✔️
userInfoEncryptionEncValuesSupported Array List of values TextArea ✔️
idTokenSigningAlgValuesSupported Array List of values TextArea ✔️
idTokenEncryptionAlgValuesSupported Array List of values TextArea ✔️
idTokenEncryptionEncValuesSupported Array List of values TextArea ✔️
accessTokenSigningAlgValuesSupported Array List of values TextArea ✔️
requestObjectSigningAlgValuesSupported Array List of values TextArea ✔️
requestObjectEncryptionAlgValuesSupported Array List of values TextArea ✔️
requestObjectEncryptionEncValuesSupported Array List of values TextArea ✔️
tokenEndpointAuthMethodsSupported Array List of values TextArea ✔️
tokenEndpointAuthSigningAlgValuesSupported Array List of values TextArea ✔️
displayValuesSupported Array List of values TextArea ✔️
claimTypesSupported Array List of values TextArea ✔️
jwksAlgorithmsSupported Array List of values TextArea ✔️
claimsLocalesSupported Array List of values TextArea ✔️
idTokenTokenBindingCnfValuesSupported Array List of values TextArea ✔️
uiLocalesSupported Array List of values TextArea ✔️
requestUriBlockList Array List of values TextArea ✔️
personCustomObjectClassList Array List of values TextArea ✔️
authenticationFilters Array List of Dicts tabs ✔️
clientAuthenticationFilters Array List of Dicts tabs ✔️
corsConfigurationFilters Array List of Dicts tabs ✔️
dynamicGrantTypeDefault Array List of values checkboxlist ✔️
clientWhiteList Array List of values TextArea ✔️
clientBlackList Array List of values TextArea ✔️
authorizationRequestCustomAllowedParameters Array List of Dicts tabs ✔️

AbdelwahabAdam added a commit that referenced this issue Nov 24, 2022
@AbdelwahabAdam
fix:jans-cli reviced all array type in properties (ref: #3062)
03c25de
moabu added a commit that referenced this issue Nov 29, 2022
@moabu @devrimyatar @AbdelwahabAdam
feat: jans cli to jans-cli-tui (#3063)
fc20e28 
* refactor: remove jans-cli

* fix: jans-cli no need to get properties each time

* feat: jans-linux-setup tui installer

* fix: jans-linux-setup clean old cli user data

* fix: jans-linux-setup missing cli libraries

* fix: jans-cli code clean OrderedDict

* fix: jans-cli runtime plugins

* fix: jans-cli don't decode if access_token_enc is empty

* fix: jans-cli edit property (ref: #3058)

* fix: jans-cli screen hangs on scim save (ref: #3061)

* fix: jans-cli multiple device auth message on save creds (ref: #3059)

* fix:jans-cli remove unnecessary logs

* fix:jans-cli reviced all array type in properties (ref: #3062)

* fix:jans-cli fix move backword in auth server column (ref: #\3073)

* fix: jans-cli delete if jca_client_secret manually added to config.ini

* fix: jans-cli typo

* fix: jans-cli config-api move to asyncio

* fix: jans-cli save admin-ui roles

* feat: jans-cli display progressing text on status bar

* feat: jans-cli progressing texts for user plugin

* fix: jans-cli decode encrypted data if salt changed

* fix: jans-cli check existence of data when logout (ref: #3050)

* fix:jans-cli getting window too small error in edit user (ref: #3041)

* fix:jans-cli remove un-used scrollbar (ref: #3070 #3041)

* feat: jans-cli add User-inum to request headers

* fix: jans-cli check existence of inum in user info

* fix: jans-cli DocString (ref: #2572)

* fix: jans-cli DocString (ref: #2572)

* fix: jans-cli DocString and removing unused imports (ref: #2572)

* fix:jans-cli Ask on delete of scripts conf. properties (ref: #3105)

* fix: jans-cli Error on deleting Claims in scopes(ref:  #3106)

* fix: jans-cli Error on deleting without verification of deletion (ref: #3107)

Co-authored-by: Mustafa Baser <mbaser@mail.com>
Co-authored-by: AbdelwahabAdam <abdelwahabosama.1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbdelwahabAdam AbdelwahabAdam

Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devrimyatar @AbdelwahabAdam