Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JARM FAPI Test Failed: fapi1-advanced-final-user-rejects-authentication #313

Closed
HemantKMehta opened this issue Nov 24, 2021 · 2 comments
Closed
Labels
comp-jans-auth-server Component affected by issue or PR effort-3 Relative effort required for completion of issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality priority-4 Minor issue or PR is not relevant to core functions, or relates to the usability of system triaged Issue or PR is fully triaged

Comments

@HemantKMehta
Copy link
Contributor

fapi1-advanced-final-user-rejects-authentication: https://www.certification.openid.net/log-detail.html?log=OMZWXbz2Ctg1KDl&public=true

Instruction on Test page: "This test requires the user to reject the authentication or consent, for example by pressing the 'cancel' button on the login screen. It verifies that the user is redirected back to the relying party's redirect_uri with an 'access_denied' error."

In this test user is supposed to reject the authentication/ consent request since we don't have the cancel button on login screen (I am trying to add it), so I am rejecting authentication request by clicking Don't Allow button on consent screen as given in screenshot.

Screenshot from 2021-11-24 10-39-03

After click on "Don't Allow", it returns back to the following URL(redirectUri) and results in "ExtractJARMFromURLQuery: Couldn't find response in callback_query_params" error

https://www.certification.openid.net/test/a/GOBD1CNFAPITestOBUK/callback?

We need to return access_denied error within the JARM response.

@HemantKMehta
Copy link
Contributor Author

Further details on this issue, Since this test is about rejecting the authentication, we don't have the cancel button on the login page (I have added cancel button but couldn't make it work) so I am rejecting the authentication by clicking don't allow on consent gathering screen.

The flow starts returning from this point by calling AuthorizeAction.permissionDenied method. In turn, the AuthorizeAction.permissionDenied method calls authorizeService.permissionDenied(session).

Finally authorizeService.permissionDenied(session) redirect to FAPI test from this line https://github.com/JanssenProject/jans-auth-server/blob/master/server/src/main/java/io/jans/as/server/service/AuthorizeService.java#L246.

Attaching log for reference jans-auth for user rejects authentication test.log

@ghost ghost assigned HemantKMehta Jan 5, 2022
@ossdhaval ossdhaval transferred this issue from another repository Jan 13, 2022
@ossdhaval ossdhaval added comp-jans-auth-server Component affected by issue or PR effort-3 Relative effort required for completion of issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality priority-4 Minor issue or PR is not relevant to core functions, or relates to the usability of system triaged Issue or PR is fully triaged labels Jan 13, 2022
moabu pushed a commit that referenced this issue Jan 13, 2022
Revert "Revert "fix: jarm alignment for fapi brazil conformance""
moabu pushed a commit that referenced this issue Jan 13, 2022
Revert "Revert "fix: jarm alignment for fapi brazil conformance""
@HemantKMehta
Copy link
Contributor Author

Completed and tested in this PR #695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-auth-server Component affected by issue or PR effort-3 Relative effort required for completion of issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality priority-4 Minor issue or PR is not relevant to core functions, or relates to the usability of system triaged Issue or PR is fully triaged
Projects
None yet
Development

No branches or pull requests

3 participants