Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jans-cli-tui missing properties #3448

Closed
2 tasks done
devrimyatar opened this issue Dec 29, 2022 · 5 comments
Closed
2 tasks done

fix: jans-cli-tui missing properties #3448

devrimyatar opened this issue Dec 29, 2022 · 5 comments
Assignees
@devrimyatar @AbdelwahabAdam
Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Milestone
1.0.7

Comments

@devrimyatar
Copy link
Contributor

devrimyatar commented Dec 29, 2022 •
edited
Loading

Describe the bug
Jans config-api server does not return all configuration properties. For example mtlsUserInfoEndpoint is missing

  • on TUI we need to have Add Properties button on Auth Server:Properties Screen, when pressed display a popup with key and value and use patch, op:add in cli operation (@AbdelwahabAdam)
  • in command line we use --patch-add argument which requires colon delimited key:value pairs, but we cant set for example mtlsUserInfoEndpoint:https://example.jans.io/mtlsuserinfo because value also contains colon (@devrimyatar)
@devrimyatar devrimyatar added kind-bug Issue or PR is a bug in existing functionality comp-jans-cli-tui Component affected by issue or PR labels Dec 29, 2022
devrimyatar added a commit that referenced this issue Dec 29, 2022
@devrimyatar
fix: jans-cli-tui parse escaped colon for patch (ref: #3448)
7bd8d26
@devrimyatar
Copy link
Contributor Author

Second part is implemented in commit 7bd8d26 , we can use escape character \ for colons, for example

/opt/jans/jans-cli/config-cli.py --operation-id=patch-properties --patch-add="mtlsUserInfoEndpoint:https\://example.jans.io/muserinfo"

@ossdhaval
Copy link
Contributor

@devrimyatar
Above fix will enable addition of mtlsUserInfoEndpoint explicitly. But the question is that, like other listed properties, why does this property not get loaded in the properties list automatically? And maybe there are more such missing properties.

@devrimyatar
Copy link
Contributor Author

@ossdhaval TUI displays what it get from config-api server. So the first fix for TUI (add property button) will fix it.

moabu pushed a commit that referenced this issue Jan 2, 2023
@devrimyatar @AbdelwahabAdam
fix: jans-cli-tui (#3287)
27e7518 
* fix(jans-cli-tui) fix Empty spaces in multi tab properties ref:(#3286)

* fix: jans-cli-tui save script location

* fix: jans-linux-tui remove updatedAt from user edit

* fix: jans-cli-tui user-edit None value

* fix:jans-cli-tui rename jans_date_picker

* fix:jans-cli-tui refactor test files for renaming jans_date_picker

* fix:jans-cli-tui fix import error

* feat:jans-cli-tui add mouse menu for cut, paste, copy (ref: #2712)

* fix:jans-cli-tui remove unused imports

* fix:jans-cli-tui change user password (ref: #3360)

* fix: jans-cli-tui imports

* Revert "fix: jans-cli-tui imports"

This reverts commit 9978479.

* fix: jans-cli-tui imports

* feat: jans-cli-tui option --no-tui

* fix:jans-cli-tui unable to search user in search box (ref: #3353)

* fix: jans-cli-tui searches should call <get>if no search string entered (ref: #3379)

* fix:jans-cli-tui reverting changes for worng user password implementation (ref: #3360)

* fix: jans-cli-tui user patch operation

* fix: rename 010_oxauth as 010_auth_server

* fix: rename oxauth to_oauth

* fix: jans-cli-tui parse escaped colon for patch (ref: #3448)

* fix: jans-cli-tui fix typo (ref: #3475)

* fix:jans-cli-tui fix script search (ref #3468)

* fix:jans-cli-tui fix script search (ref #3468)

* fix: jan-cli-tui add none option to tokenEndpointAuthMethod (ref: #3463)

* fix: jans-cli-tui code smells

* fix: jans-cli-tui code smells

* fix: jans-cli-tui code smells

* fix: jans-cli-tui code smells

* fix: jans-cli-tui typo

Co-authored-by: AbdelwahabAdam <abdelwahabosama.1@gmail.com>
@moabu moabu added this to the 1.0.7 milestone Jan 9, 2023
@devrimyatar
Copy link
Contributor Author

Implemented

@devrimyatar
Copy link
Contributor Author

Missing properties are listed in dialog when you press Add Property button

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devrimyatar devrimyatar

@AbdelwahabAdam AbdelwahabAdam

Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.0.7
Development

No branches or pull requests
4 participants
@ossdhaval @devrimyatar @moabu @AbdelwahabAdam