Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-cli-tui): after updating client popup is not closing #3510

Closed
manojs1978 opened this issue Jan 4, 2023 · 0 comments · Fixed by #3504
Closed

fix(jans-cli-tui): after updating client popup is not closing #3510

manojs1978 opened this issue Jan 4, 2023 · 0 comments · Fixed by #3504
Assignees
@devrimyatar @AbdelwahabAdam
Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Milestone
1.0.7

Comments

@manojs1978
Copy link
Contributor

Describe the bug
after updating client popup is not closing

To Reproduce
Steps to reproduce the behavior:

  1. launch jans-tui
  2. edit auth client
  3. modify some attribute and click on save

Expected behavior
after updating client and click on save button , popup is not closing

Screenshots
If applicable, add screenshots to help explain your problem.

updateauthclient-2023-01-04_14.29.41.mp4

Desktop (please complete the following information):

  • OS: ubuntu
  • Browser [
  • Version 20
  • DB mysql

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@manojs1978 manojs1978 added kind-bug Issue or PR is a bug in existing functionality comp-jans-cli-tui Component affected by issue or PR labels Jan 4, 2023
@moabu moabu added this to the 1.0.7 milestone Jan 9, 2023
devrimyatar added a commit that referenced this issue Jan 9, 2023
@devrimyatar
fix: jans-cli-tui close dialog after updating client (ref: #3510)
25e0b7a
@devrimyatar devrimyatar mentioned this issue Jan 9, 2023
Merged
@moabu moabu assigned devrimyatar and AbdelwahabAdam and unassigned moabu Jan 10, 2023
yuriyz pushed a commit that referenced this issue Jan 19, 2023
@devrimyatar @AbdelwahabAdam
fix: jans-cli-tui working branch 4 - many different improvements (#3504)
e572552 
* fix:jans-cli-tui change user password (ref: #3360)

* fix:jans-cli-tui show kid for each key (ref: #3405)

* fix:jans-cli-tui improve Scope Management for OpenID Client (ref: #3460)

* fix:jans-cli-tui remove repeated import

* fix:jans-cli-tui change the Quit key to  (ref: #3502)

* fix: jans-cli-tui ctrl+c and ctrl+q to exit

* feat: jans-cli-tui status bar message for listbox

* fix: jans-cli-tui code smells

* fix: jans-cli-tui sort properties for ease of navigation

* fix: enabled components are checked for porperties (ref: #3438)

* feat: jans-cli-tui add missing property

* fix:jans-cli-tui make list for scopes -baseDn and displayName- (ref: #3460)

* fix: jans-cli-tui Improve Scope Management for OpenID Client (ref: #3460)

* fix: jans-tui-client rewrite properties

* fix: jans-cli-tui remove debug line

* fix: jans-cli-tui code smells

* fix: jans-cli-tui typo

* fix: jans-cli-tui code smells

* fix: jans-cli-tui widget style for checkbox

* fix: jans-cli-tui remove unused imports

* fix: jans-cli-tui close dialog after updating client (ref: #3510)

* fix:jans-cli-tui add Scopes label and reverse Scopes columns

* fix: jans-cli-tui uppercase cli

* fix:jans-cli-tui Fixing Client dialog title

* fix:jans-cli-tui re-implementing Scopes

* fix:jans-cli-tui change background color and styling (ref: #3408)

* feat: jans-cli-tui label container widget (ref: #3631)

* fix: jans-cli-tui rewrite client scopes with lable container

* fix: jans-cli-tui save client scopes

* fix: jans-cli-tui only save client scopes no patch

* fix: jans-cli-tui client edit after save

* feat: jans-cli-tui check available plugins from config-api (ref: #3616)

* fix: jans-cli-tui code smells

* fix: jans-cli-tui on_display for label container

* fix: jans-cli-tui code smells

* fix: jans-cli-tui code smells

Co-authored-by: AbdelwahabAdam <abdelwahabosama.1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devrimyatar devrimyatar

@AbdelwahabAdam AbdelwahabAdam

Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.0.7
Development

Successfully merging a pull request may close this issue.

fix: jans-cli-tui working branch 4 JanssenProject/jans
4 participants
@manojs1978 @devrimyatar @moabu @AbdelwahabAdam