Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jans-tui-client TUI only saves client properties displayed on screen #3650

Closed
devrimyatar opened this issue Jan 20, 2023 · 0 comments · Fixed by #3649
Closed

fix: jans-tui-client TUI only saves client properties displayed on screen #3650

devrimyatar opened this issue Jan 20, 2023 · 0 comments · Fixed by #3649
Assignees
Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@devrimyatar
Copy link
Contributor

Describe the bug
TUI saves only those properties displayed on screen, but we have some additional information coming from config-api-server. For example, we have property trustedClient in the original data coming from config-api server. This data is not posted to config-api server and hance it is set to default. TUI should not touch any incoming property that is not displayed on screen.

@devrimyatar devrimyatar self-assigned this Jan 20, 2023
@devrimyatar devrimyatar added kind-bug Issue or PR is a bug in existing functionality comp-jans-cli-tui Component affected by issue or PR labels Jan 20, 2023
yuriyz pushed a commit that referenced this issue Feb 1, 2023
* fix: jans-cli-tui typo

* fix: jans-cli-tui re-post those propery we don't modify for client (ref: #3650)

* fix:jans-cli-tui disabling line wrap

* fix:jans-cli-tui fix all List JansVerticalNav and give it one space to the right (ref: #3659)

* fix: jans-cli-tui remove the cursor from all List items (ref: #3663)

* fix: jans-cli-tui check if valid json for json claims in edit user

* fix: jans-cli-tui code smell

* fix: jans-cli-tui rename config-api swagger file

* feat: jans-cli-tui jans-auth mode

* fix:jans-cli-tui fix focus on jans_label_container when empty (ref: #3722)

* fix: jans-cli-tui ssa management (ref: #3686)

* fix: jans-cli-tui code smells

* fix: jans-cli-tui ssa never expire is 50 years lifetime

* fix: jans-cli-tui ssa timestamp check

---------

Co-authored-by: AbdelwahabAdam <abdelwahabosama.1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant